Skip to content

Ignore body elements on VCR match#142

Merged
nwithan8 merged 2 commits intomasterfrom
vcr_040
Jun 14, 2022
Merged

Ignore body elements on VCR match#142
nwithan8 merged 2 commits intomasterfrom
vcr_040

Conversation

@nwithan8
Copy link
Copy Markdown
Contributor

@nwithan8 nwithan8 commented Jun 13, 2022 •
edited
Loading

Description

  • Implement EasyVCR 0.3.0
  • Ignore body elements during match that would otherwise cause a match failure

Testing

Most unit tests pass as expected (referral add credit card disabled for now, likely due to Stripe API call not being recorded)

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

Justintime50
Justintime50 reviewed Jun 13, 2022
View reviewed changes
Comment thread cassettes/referral/referral_add_credit_card.json Outdated
Comment thread src/test/java/com/easypost/TestUtils.java Outdated
Comment thread src/test/java/com/easypost/TestUtils.java
Comment thread src/test/java/com/easypost/beta/ReferralTest.java Outdated
@nwithan8
- Implement EasyVCR 0.4.0
65ef2fc 
- Ignore body elements during match
@nwithan8 nwithan8 requested a review from Justintime50 June 13, 2022 23:14
jchen293
jchen293 approved these changes Jun 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description, the version of the EasyVCR is actually 0.3.0

@nwithan8 nwithan8 merged commit dc6daa8 into master Jun 14, 2022
@nwithan8 nwithan8 deleted the vcr_040 branch June 14, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

+1 more reviewer

@jchen293 jchen293 jchen293 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nwithan8 @jchen293 @Justintime50